Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/eng 2374 account selection dropdown click behaviour #509

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Jul 9, 2023

πŸ”˜ PR Type

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

πŸ“œ Background

Issue Link: https://linear.app/xverseapp/issue/ENG-2374/account-selection-dropdown-click-behaviour
Context Link (if applicable):

πŸ”„ Changes

  • fix for account select menu
    • make each account row clickable
    • fix react warnings for nested buttons
    • use event.stopPropagation for (child component) copy address buttons

Impact:

  • limited to account row on account select menu

πŸ–Ό Screenshot / πŸ“Ή Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

Screen.Recording.2023-07-09.at.12.24.38.PM.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

and fix react warnings for nested buttons
@linear
Copy link

linear bot commented Jul 9, 2023

ENG-2374 Account selection dropdown click behaviour

the whole row needs to be clickable - actionable, I caught myself clicking and expected for the account to switch ... Only the area of the button is clickable, which is a 1/3 of the whole row

The issue is not present on prod

image.png

image.png

@teebszet teebszet changed the base branch from develop to ledger-btc-mvp July 9, 2023 04:21
@teebszet teebszet merged commit 0a0df9c into ledger-btc-mvp Jul 10, 2023
1 check passed
@teebszet teebszet deleted the tim/eng-2374-account-selection-dropdown-click-behaviour branch July 10, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants